Add Draft 7 to 2019-09 upgrade rules #20
Conversation
|
Very cool! Let me give it a proper careful look tomorrow |
|
Two initial overall comments:
|
|
Also, if we will go for numeric prefixes, I think you should also add them to the 2019-09 => 2020-12 existing rules, so that the entire repo is consistent. Maybe do those as a quick separate PR? |
| "deprecated": "newbie" | ||
| }, | ||
| "to": { | ||
| "x-deprecated": "newbie" |
There was a problem hiding this comment.
I don't think this is correct. 2019-09 does have the deprecated keyword: https://www.learnjsonschema.com/2019-09/meta-data/deprecated/
There was a problem hiding this comment.
😐 Draft 7 doesn't have deprecated keyword, 2019 has. So, if the type of deprecated is object or something invalid then it will be invalid in 2019
There was a problem hiding this comment.
Ahhhhhhhhh I remember this now. I wonder if we can make the rule names more descriptive, as if I got confused, others might get confused too. Maybe call them i.e. unknown-before-deprecated or something like that?
There was a problem hiding this comment.
I'll say unknown-inp-reviosu-draft-{keyword}..
| { | ||
| "title": "maxContains present in the schema", | ||
| "from": { | ||
| "maxContains": "newbie" |
There was a problem hiding this comment.
maxContains is also present in 2019-09: https://www.learnjsonschema.com/2019-09/validation/maxcontains/.
| { | ||
| "title": "minContains present in the schema", | ||
| "from": { | ||
| "minContains": "newbie" |
There was a problem hiding this comment.
Same here. Also present. Maybe you mis-read the spec?
|
Another big one is that I see a lot of tests removing keywords that in fact do exist in 2019-09. Maybe you mis-read the spec? Can you handle those first? I think it will make the rest of the PR easier to review. You can see all 2019-09 keywords here: https://www.learnjsonschema.com/2019-09/ |
Hm.... I think you missed what the rules tries to convey, maybe I should rename the rule title to |
|
Let me also break the PR 😅 |
|
Haha yes. I forgot about that. Maybe let's make the rule names a bit more descriptive so that others don't get confused too? Cool that you are breaking the PR. Probably easy to review. Let me know when you have done so! |
@jviotti I have added the rules for draft7 to 2019-09 except for ignore adjacent keywords when $ref is present
I have tested the rules.
Please review the PR