Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR added commits related to smach_to_mail.py that is in develop/fetch branch #1884

Merged
merged 8 commits into from
Oct 31, 2023

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Oct 27, 2023

@tkmtnt7000 Please check if this PR works and that it incldues all commits related to smach_to_mail.py that is in develop/fetch branch.

If you have tested a new feature or fix a serious bug on one robot and found it worth installing on othre robots, you may want to I suggest you create new PR against master branch and ask other robots to rebase origin/master

Related PRs

c.f. #1882

@k-okada k-okada requested a review from tkmtnt7000 October 27, 2023 03:19
@k-okada k-okada force-pushed the update_smach_to_mail_tsukamoto branch from 3f19dac to 508df72 Compare October 27, 2023 04:47
@k-okada k-okada force-pushed the update_smach_to_mail_tsukamoto branch from 508df72 to 56b5448 Compare October 27, 2023 07:53
@tkmtnt7000
Copy link
Member

Sorry for late and thank you very much for your advice. (I don't know why I forgot making PR to master branch...)

@tkmtnt7000 Please check if this PR works and that it incldues all commits related to smach_to_mail.py that is in develop/fetch branch.
If you have tested a new feature or fix a serious bug on one robot and found it worth installing on othre robots, you may want to I suggest you create new PR against master branch and ask other robots to rebase origin/master

I left a single comment, but I confirmed this PR woks at my local PC.

Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating.

@k-okada k-okada merged commit ddf454d into jsk-ros-pkg:master Oct 31, 2023
8 checks passed
@k-okada k-okada deleted the update_smach_to_mail_tsukamoto branch October 31, 2023 08:55
@k-okada
Copy link
Member Author

k-okada commented Oct 31, 2023

@tkmtnt7000 please rebase origin/master at fetcha nd pr2 branch

@tkmtnt7000
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants