Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsk_travis to 0.5.17 and fix travis #1288

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 26, 2020

@pazeshun
Copy link
Contributor

jsk_travis lost backward compatibility since 0.5.15.
At least, we have to use .travis/travis.sh instead of source .travis/travis.sh on .travis.yml like https://github.com/jsk-ros-pkg/jsk_travis/blob/0.5.17/.travis.yml#L102.
Please see jsk-ros-pkg/jsk_travis#410 (comment), jsk-ros-pkg/jsk_travis#410 (comment), jsk-ros-pkg/jsk_travis#410 (comment).
I'm not sure whether @k-okada prefers not updating jsk_travis on repositories other than jsk_recognition or he prefers fixing these repositories to use the latest jsk_travis at their convinience.

@k-okada
Copy link
Member

k-okada commented Nov 27, 2020

I'm not sure whether @k-okada prefers not updating jsk_travis on repositories other than jsk_recognition or he prefers fixing these repositories to use the latest jsk_travis at their convinience.

jsk-ros-pkg/jsk_travis#410 simply cleanup travis result. I updatde jsk_recognition because at that time, I am working with that repository and having better travis output helps debugging.

But unless you have any strong reason, you do not have to update .travis.yml settings just for this. This is the advanteage of using submodules, instead of cloning ci module everytime (https://github.com/ros-planning/moveit_ros/blob/kinetic-devel/.travis.yml#L21).

updating jsk_travis in this PR seems nice to me.

スクリーンショット 2020-11-27 123913
スクリーンショット 2020-11-27 125936

@knorth55
Copy link
Member Author

I preferred latter one because the out log is simpler and shorter.

@knorth55 knorth55 changed the title Update jsk_travis and remove released packages from .travis.rosinstall Update jsk_travis to 0.5.17 and fix travis Nov 27, 2020
@knorth55
Copy link
Member Author

knorth55 commented Nov 29, 2020

Travis passed!
Current master branch test fails because we require the latest jsk_maps fetch_ros.
I also request the release of fetch_ros, too.
ZebraDevs/fetch_ros#139

@knorth55
Copy link
Member Author

knorth55 commented Nov 29, 2020

Travis passed.
https://travis-ci.org/github/jsk-ros-pkg/jsk_robot/builds/746261820

@k-okada k-okada merged commit 71fbbae into jsk-ros-pkg:master Nov 30, 2020
@knorth55 knorth55 deleted the update-travis-rosinstall branch November 30, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants