posedetection_msgs: add object_detection_aggregator #24
+273
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add example, document and test code (if possible) |
|
May be we have to update jsk_travis |
k-okada
reviewed
Mar 19, 2019
| <run_depend>message_filters</run_depend> | ||
| <run_depend>message_runtime</run_depend> |
There was a problem hiding this comment.
please separate style change and your contribution, when I first see this patch, it seems you have increased a lot of dependencies and since the jsk_common_msgs is the root node of jsk repositories, it is not acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working version of object_detection_aggregator.