Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and Shaded Library Problem #322

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2021

Hi guys!
I am hesitating if you still have enough time to maintain this awesome library but I will try to contribute.
Be sure this tool still is one of the bests (and I believe the lightest one among the nosan and testcontainer-cassandra) for integration testing with Cassandra.

I have changed two things:

  1. I've added Netty dependency in the cassandra-unit pom avoiding crashes related to not being to find netty classes in the cassandra-unit-shaded I've experienced.

This change also may resolve issues #248, #276, and #320 this way: Simply use the cassandra-unit-shaded so that you will not experience dep conflicts causing NoSuchField, NoSuchMethod, etc.

  1. I've added GitHub actions to automate build and test. I hope to give some advice on how to automate even the release phase to have a complete continuous delivery pipeline.

Be Happy!

@asarkar
Copy link

asarkar commented May 1, 2021

how to automate even the release phase

You can release to Maven Central from a GitHub action only if build and tests have passed. See this project for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants