fix re-mounting ParallaxProvider #9

jscottsmith · Oct 25, 2017 · 82982c7 · 82982c7
1 parent f940f9d
commit 82982c7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/example/components/App/App.js b/example/components/App/App.js
@@ -1,14 +1,24 @@
 import React, { Component } from 'react';
-// import PropTypes from 'prop-types';
 import { ParallaxProvider } from 'react-scroll-parallax';
 import { ParallaxTest } from 'components';
 
 export default class App extends Component {
+    // this just serves to test unmount/re-mount ParallaxProvider
+    state = {
+        mount: true,
+    };
+
     render() {
         return (
-            <ParallaxProvider>
-                <ParallaxTest />
-            </ParallaxProvider>
+            <main>
+                {this.state.mount ? (
+                    <ParallaxProvider>
+                        <ParallaxTest />
+                    </ParallaxProvider>
+                ) : (
+                    <div />
+                )}
+            </main>
         );
     }
 }
diff --git a/src/libs/ParallaxController.js b/src/libs/ParallaxController.js
@@ -389,6 +389,7 @@ function ParallaxController() {
     this.destroy = function() {
         _removeListeners();
         _removeParallaxStyles();
+        window.ParallaxController = null;
     };
 }