Cache S3 key metadata to avoid unnecessary calls especially with collectstatic #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance we can move this issue forward? :) |
|
Does this work in a multi threaded environment or does the cache need a lock? |
|
+1 for this PR, will really increase a speed of my deployment :) @jschneier, from their docs cachetools are not thread-safe (https://cachetools.readthedocs.io/en/stable/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1255
When running
collectstaticS3 key check first the existence and the last modification time. With this change the latter call is avoided. Previously last modification fetched the whole object and didn't use the metadata. This cause a lot of unnecessary traffic and thus makingcollectstaticslow.