Node x3d support #212
Merged
Node x3d support #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added dependency - modified CSGToX3d module to work both in browser & node - updated tests
Merged
kaosat-dev
force-pushed
the
node-x3d-support
branch
2 times, most recently
from
1f2a50d to
678cfa7
Compare
|
Why DOM? Why not reuse the SAX library? Just wondering... |
|
SAX is just a parser , not a writer, and I used |
kaosat-dev
pushed a commit
that referenced
this pull request
Mar 12, 2019
Enhancements for exporting X3D from NODEJS based scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds node.js support to export to X3D (you should be happy about this one @mtippett :)
IMPORTANT : please merge this PR after #211