refactor(modeling)!: no geometry clone

packages/modeling/src/colors/colorize.js

@@ -6,27 +6,19 @@ import * as path2 from '../geometries/path2/index.js'
 import * as poly3 from '../geometries/poly3/index.js'
 
 const colorGeom2 = (color, object) => {
-  const newGeom2 = geom2.clone(object)
-  newGeom2.color = color
-  return newGeom2
+  return Object.assign({}, object, { color })
 }
 
 const colorGeom3 = (color, object) => {
-  const newGeom3 = geom3.clone(object)
-  newGeom3.color = color
-  return newGeom3
+  return Object.assign({}, object, { color })
 }
 
 const colorPath2 = (color, object) => {
-  const newPath2 = path2.clone(object)
-  newPath2.color = color
-  return newPath2
+  return Object.assign({}, object, { color })
 }
 
 const colorPoly3 = (color, object) => {
-  const newPoly = poly3.clone(object)
-  newPoly.color = color
-  return newPoly
+  return Object.assign({}, object, { color })
 }
 
 /**

packages/modeling/src/connectors/create.js

@@ -18,4 +18,4 @@ import * as vec3 from '../maths/vec3/index.js'
  * @example
  * let myConnector = create()
  */
-export const create = () => ({ point: vec3.create(), axis: vec3.clone([0, 0, 1]), normal: vec3.clone([1, 0, 0]) })
+export const create = () => ({ point: vec3.create(), axis: [0, 0, 1], normal: [1, 0, 0] })

packages/modeling/src/geometries/geom2/fromCompactBinary.js

@@ -14,7 +14,7 @@ export const fromCompactBinary = (data) => {
 
   const created = create()
 
-  created.transforms = mat4.clone(data.slice(1, 17))
+  created.transforms = data.slice(1, 17)
 
   for (let i = 21; i < data.length;) {
     const length = data[i++] // number of points for this polygon

packages/modeling/src/geometries/geom2/index.d.ts

@@ -1,4 +1,3 @@
-export { clone } from './clone'
 export { create } from './create'
 export { fromSides } from './fromSides'
 export { fromCompactBinary } from './fromCompactBinary'

packages/modeling/src/geometries/geom2/index.js

@@ -8,7 +8,6 @@
  * import { geometries } from '@jscad/modeling'
  * let myShape = geometries.geom2.create([ [[-1,-1], [1,-1], [1,1], [-1,1]] ])
  */
-export { clone } from './clone.js'
 export { create } from './create.js'
 export { fromSides } from './fromSides.js'
 export { fromCompactBinary } from './fromCompactBinary.js'

packages/modeling/src/geometries/geom2/reverse.js

@@ -1,4 +1,3 @@
-import { clone } from './clone.js'
 
 /**
  * Reverses the given geometry so that the outline points are flipped in the opposite order.
@@ -11,7 +10,7 @@ import { clone } from './clone.js'
  * let newGeometry = reverse(geometry)
  */
 export const reverse = (geometry) => {
-  const reversed = clone(geometry)
+  const reversed = Object.assign({}, geometry)
   reversed.outlines = reversed.outlines.map((outline) => outline.slice().reverse())
   return reversed
 }

packages/modeling/src/geometries/geom3/fromCompactBinary.js

@@ -16,7 +16,7 @@ export const fromCompactBinary = (data) => {
 
   const created = create()
 
-  created.transforms = mat4.clone(data.slice(1, 17))
+  created.transforms = data.slice(1, 17)
 
   const numberOfVertices = data[21]
   let ci = 22

packages/modeling/src/geometries/geom3/index.d.ts

@@ -1,4 +1,3 @@
-export { clone } from './clone'
 export { create } from './create'
 export { fromPoints } from './fromPoints'
 export { fromCompactBinary } from './fromCompactBinary'

packages/modeling/src/geometries/geom3/index.js

@@ -14,7 +14,6 @@
  *   [[-1,-1,1], [1,-1,1], [1,1,1], [-1,1,1]]
  * ])
  */
-export { clone } from './clone.js'
 export { create } from './create.js'
 export { fromPoints } from './fromPoints.js'
 export { fromCompactBinary } from './fromCompactBinary.js'

packages/modeling/src/geometries/path2/appendArc.js

@@ -36,11 +36,10 @@ export const appendArc = (options, geometry) => {
 
   // validate the given options
   if (!Array.isArray(endpoint)) throw new Error('endpoint must be an array of X and Y values')
-  if (endpoint.length < 2) throw new Error('endpoint must contain X and Y values')
-  endpoint = vec2.clone(endpoint)
+  if (endpoint.length !== 2) throw new Error('endpoint must contain X and Y values')
 
   if (!Array.isArray(radius)) throw new Error('radius must be an array of X and Y values')
-  if (radius.length < 2) throw new Error('radius must contain X and Y values')
+  if (radius.length !== 2) throw new Error('radius must contain X and Y values')
 
   if (segments < 4) throw new Error('segments must be four or more')
 

packages/modeling/src/geometries/path2/close.js

@@ -2,8 +2,6 @@ import { EPS } from '../../maths/constants.js'
 
 import * as vec2 from '../../maths/vec2/index.js'
 
-import { clone } from './clone.js'
-
 /**
  * Close the given geometry.
  * @param {path2} geometry - the path to close
@@ -13,7 +11,7 @@ import { clone } from './clone.js'
 export const close = (geometry) => {
   if (geometry.isClosed) return geometry
 
-  const cloned = clone(geometry)
+  const cloned = Object.assign({}, geometry)
   cloned.isClosed = true
 
   if (cloned.points.length > 1) {

packages/modeling/src/geometries/path2/fromCompactBinary.js

@@ -14,7 +14,7 @@ export const fromCompactBinary = (data) => {
 
   const created = create()
 
-  created.transforms = mat4.clone(data.slice(1, 17))
+  created.transforms = data.slice(1, 17)
 
   created.isClosed = !!data[17]
 

packages/modeling/src/geometries/path2/fromPoints.js

@@ -22,8 +22,7 @@ export const fromPoints = (options, points) => {
   const defaults = { closed: false }
   let { closed } = Object.assign({}, defaults, options)
 
-  let created = create()
-  created.points = points.map((point) => vec2.clone(point))
+  let created = create(points)
 
   // check if first and last points are equal
   if (created.points.length > 1) {

packages/modeling/src/geometries/path2/index.d.ts

@@ -1,7 +1,6 @@
 export { appendArc, AppendArcOptions } from './appendArc'
 export { appendBezier, AppendBezierOptions } from './appendBezier'
 export { appendPoints } from './appendPoints'
-export { clone } from './clone'
 export { close } from './close'
 export { concat } from './concat'
 export { create } from './create'

packages/modeling/src/geometries/path2/index.js

@@ -10,7 +10,6 @@
 export { appendArc } from './appendArc.js'
 export { appendBezier } from './appendBezier.js'
 export { appendPoints } from './appendPoints.js'
-export { clone } from './clone.js'
 export { close } from './close.js'
 export { concat } from './concat.js'
 export { create } from './create.js'

packages/modeling/src/geometries/path2/reverse.js

@@ -1,4 +1,3 @@
-import { clone } from './clone.js'
 
 /**
  * Reverses the path so that the points are in the opposite order.
@@ -12,7 +11,7 @@ import { clone } from './clone.js'
  */
 export const reverse = (geometry) => {
   // NOTE: this only updates the order of the points
-  const cloned = clone(geometry)
+  const cloned = Object.assign({}, geometry)
   cloned.points = geometry.points.slice().reverse()
   return cloned
 }

packages/modeling/src/geometries/poly2/index.d.ts

@@ -1,5 +1,4 @@
 export { arePointsInside } from './arePointsInside'
-export { clone } from './clone'
 export { create } from './create'
 export { isA } from './isA'
 export { isConvex } from './isConvex'

packages/modeling/src/geometries/poly2/index.js

@@ -8,7 +8,6 @@
  * const p1 = geometries.poly2.create([[0,0], [4,0], [4,3]])
  */
 export { arePointsInside } from './arePointsInside.js'
-export { clone } from './clone.js'
 export { create } from './create.js'
 export { isA } from './isA.js'
 export { isConvex } from './isConvex.js'

packages/modeling/src/geometries/poly3/index.d.ts

@@ -1,4 +1,3 @@
-export { clone } from './clone'
 export { create } from './create'
 export { fromVerticesAndPlane } from './fromVerticesAndPlane'
 export { invert } from './invert'

packages/modeling/src/geometries/poly3/index.js

@@ -7,7 +7,6 @@
  * import { geometries } from '@jscad/modeling'
  * const polygon = geometries.poly3.create([[0,0,0], [4,0,0], [4,3,12]])
  */
-export { clone } from './clone.js'
 export { create } from './create.js'
 export { fromVerticesAndPlane } from './fromVerticesAndPlane.js'
 export { invert } from './invert.js'