Fix extended coverage main pipeline bug (ThreeMammals#510)

js8080 · Jul 30, 2018 · 8711b07 · 8711b07
1 parent b0a20d1
commit 8711b07
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/Ocelot/Middleware/Pipeline/OcelotPipelineBuilderExtensions.cs b/src/Ocelot/Middleware/Pipeline/OcelotPipelineBuilderExtensions.cs
@@ -172,7 +172,7 @@ public static IOcelotPipelineBuilder MapWhen(this IOcelotPipelineBuilder app, Fu
                 throw new ArgumentNullException(nameof(pipelineBuilderFunc));
             }
             var branchBuilder = app.New();
-            var predicate = pipelineBuilderFunc.Invoke(app);
+            var predicate = pipelineBuilderFunc.Invoke(branchBuilder);
             var branch = branchBuilder.Build();
 
             var options = new MapWhenOptions

diff --git a/src/Ocelot/Middleware/Pipeline/OcelotPipelineExtensions.cs b/src/Ocelot/Middleware/Pipeline/OcelotPipelineExtensions.cs
@@ -28,15 +28,6 @@ public static OcelotRequestDelegate BuildOcelotPipeline(this IOcelotPipelineBuil
             // It also sets the Request Id if anything is set globally
             builder.UseExceptionHandlerMiddleware();
 
-            //Expand other branch pipes
-            if (pipelineConfiguration.MapWhenOcelotPipeline != null)
-            {
-                foreach (var pipeline in pipelineConfiguration.MapWhenOcelotPipeline)
-                {
-                    builder.MapWhen(pipeline);
-                }
-            }
-
             // If the request is for websockets upgrade we fork into a different pipeline
             builder.MapWhen(context => context.HttpContext.WebSockets.IsWebSocketRequest,
                 app =>
@@ -57,6 +48,15 @@ public static OcelotRequestDelegate BuildOcelotPipeline(this IOcelotPipelineBuil
             // Then we get the downstream route information
             builder.UseDownstreamRouteFinderMiddleware();
 
+            //Expand other branch pipes
+            if (pipelineConfiguration.MapWhenOcelotPipeline != null)
+            {
+                foreach (var pipeline in pipelineConfiguration.MapWhenOcelotPipeline)
+                {
+                    builder.MapWhen(pipeline);
+                }
+            }
+
             // Now we have the ds route we can transform headers and stuff?
             builder.UseHttpHeadersTransformationMiddleware();