Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatScreenMixin Refactor/Compat #11

Closed
wants to merge 1 commit into from
Closed

ChatScreenMixin Refactor/Compat #11

wants to merge 1 commit into from

Conversation

matthewperiut
Copy link

This commit maintains functionality, while improving readability and compatibility with mixins into the same class.
Before this commit compatibility with SPC 0.4.0 was poor due to this mixin.

@js6pak
Copy link
Owner

js6pak commented Nov 1, 2023

This change would mean that mojangfix has to maintain text input patches in 2 places (TextFieldWidgetMixin and ChatScreenMixin). The problem with that approach is that you can forget to implement all features in all places, which is exactly what happened in this PR: HOME/END keys no longer work.
Looking at spc-babric patches they look too complex to handle compatibility cleanly without either making it hard depend on mojangfix or making it disable mojangfix ChatScreen mixins.

@matthewperiut
Copy link
Author

You're right about that, I made large changes without considering all the effects.

@matthewperiut matthewperiut deleted the fix-instrusive-chat-mixin branch November 25, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants