Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs:Tests: Remove obsolete code from tests, update support comments #2949

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

mgol
Copy link
Member

@mgol mgol commented Feb 25, 2016

Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.

Fixes gh-2868

The first commit is PR #2948, I just didn't want to introduce conflicts between my 2 PRs. I'll rebase once that lands.

@mgol
Copy link
Member Author

mgol commented Feb 25, 2016

I could update the support comments to conform to @gibson042's proposal at jquery/contribute.jquery.org#95 (comment) since I'm already modifying a lot of them. Do we have a consensus on that? (This would involve changing some IE 9-11 only to IE <=9 - 11 only as the issues often exist in older IE versions as well).

// XHTML parsers do not magically insert elements in the
// same way that tag soup parsers do. So we cannot shorten
// this by omitting <tbody> or other required elements.
option: [ 1, "<select multiple='multiple'>", "</select>" ],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraneous line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to separate option from the table-related entries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you would like to move code around, that just creates trash in the blame

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not "moving code around", I just thought the XHTML-related comment applies to this line as well. Doesn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i recall, we know that would break only in table elements

@mgol mgol force-pushed the old-browsers-cleanup branch from 23cf92c to 578d1ec Compare March 2, 2016 12:14
Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.

Fixes jquerygh-2868
Closes jquerygh-2949
@mgol mgol force-pushed the old-browsers-cleanup branch from 578d1ec to 9b08688 Compare March 8, 2016 22:27
@mgol mgol merged commit 9b08688 into jquery:master Mar 8, 2016
@mgol mgol deleted the old-browsers-cleanup branch March 8, 2016 22:32
@mgol mgol removed the Needs review label Sep 25, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants