-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
@@ -1,5 +1,5 @@ | |||
<!doctype html> | |||
<html> | |||
<html lang="es"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not in Spanish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point :-)
@@ -0,0 +1,58 @@ | |||
/*! aXe-grunt-webdriver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Repo is licensed MIT and this is licensed under a much more restrictive MPL license and having this file here would violate our current license. https://github.com/jquery/css-chassis/blob/master/LICENSE.txt#L33 The easiest way to be able to use this would be to have it published on NPM so we could just create a devDependency
on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I could pull it out into a separate module that has a dependency on selenium-webdriver. This would solve both problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats exactly what i had in mind thank you!
9682bb6
to
0aef58e
Compare
ok, I have replaced the custom code with the |
I get this error
Other than that, Runs on firefox and works great. This is gonna be awesome. 👍 Definitely very Beneficial for us |
@geekman-rohit I have removed the chrome dependent tests, these are redundant anyway and Chrome does not work on Travis-CI |
Closed PR to merge conflicts |
This is a preliminary pull request that we can use to discuss the approach. It adds the axe-core library and Grunt changes to test the demo file(s)
Fixes #99