Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

Build: add accessibility testing #110

Closed
wants to merge 1 commit into from

Conversation

dylanb
Copy link

@dylanb dylanb commented Jul 29, 2015

This is a preliminary pull request that we can use to discuss the approach. It adds the axe-core library and Grunt changes to test the demo file(s)

Fixes #99

@@ -1,5 +1,5 @@
<!doctype html>
<html>
<html lang="es">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not in Spanish.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point :-)

@@ -0,0 +1,58 @@
/*! aXe-grunt-webdriver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Repo is licensed MIT and this is licensed under a much more restrictive MPL license and having this file here would violate our current license. https://github.com/jquery/css-chassis/blob/master/LICENSE.txt#L33 The easiest way to be able to use this would be to have it published on NPM so we could just create a devDependency on it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I could pull it out into a separate module that has a dependency on selenium-webdriver. This would solve both problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats exactly what i had in mind thank you!

@dylanb dylanb force-pushed the a11y_testing branch 2 times, most recently from 9682bb6 to 0aef58e Compare July 31, 2015 04:02
@dylanb
Copy link
Author

dylanb commented Jul 31, 2015

ok, I have replaced the custom code with the axe-grunt-webdriver module. I think this addresses all the issues.

@geekman-rohit
Copy link
Contributor

I get this error

Warning: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://chromedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH. Use --force to continue.

Other than that, Runs on firefox and works great. This is gonna be awesome. 👍 Definitely very Beneficial for us

@dylanb
Copy link
Author

dylanb commented Aug 1, 2015

@geekman-rohit I have removed the chrome dependent tests, these are redundant anyway and Chrome does not work on Travis-CI

@dylanb dylanb closed this Aug 4, 2015
@dylanb
Copy link
Author

dylanb commented Aug 4, 2015

Closed PR to merge conflicts

@dylanb dylanb deleted the a11y_testing branch August 4, 2015 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants