fix: add appearance: button for better cross-browser button styling c… #2677
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@in-ch As |
in-ch
pushed a commit
to in-ch/react-big-calendar
that referenced
this pull request
Nov 25, 2024
in-ch
force-pushed
the
master
branch
2 times, most recently
from
7d166d6
to
d9333d9
Compare
|
@cutterbl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2676
Currently, the CSS for button styling uses only -webkit-appearance: button, which ensures consistent styling across WebKit-based browsers (e.g., Chrome, Safari). However, the CSS property appearance: button is now part of the standard specification and is supported by a wider range of modern browsers, including Firefox.
To improve cross-browser compatibility and align with the CSS specification, we should include appearance: button in addition to -webkit-appearance: button. This will provide a more consistent button appearance across all major browsers that support the standard appearance property, while maintaining compatibility with older WebKit-based browsers via the -webkit-appearance fallback.
Suggested solution
Add appearance: button; alongside -webkit-appearance: button; in the button CSS.
This will ensure that browsers supporting the standard appearance property apply it, while browsers that rely on -webkit-appearance will continue to function as expected.