Correcting runWithHTMLReturn2() Function in test.py #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, runWithHTMLReturn2() function was iterating over the name of test script received from the run() function but to get the report in defined format of define.py TestMessage class it should iterate over list of TestMessage received from runWithReport() function and it was finally returning single test but it should return ret variable containing all tests.
|
Thanks! I don't know much about this function. #122 (comment) says:
Are you an existing user of this function, and its behavior broke at some point? If you are using it, don't suppose you could add a docstring for it? Or even a test? :) Please let me know - would be helpful to know the answers before reviewing your change. |
|
Closing as stale, but happy to re-open in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, runWithHTMLReturn2() function was iterating over the name of test script received from the run() function but to get the report in defined format of define.py TestMessage class it should iterate over list of TestMessage received from runWithReport() function and it was finally returning single test but it should return ret variable containing all tests.