Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track cell+test execution #113

Merged
merged 3 commits into from
May 20, 2020
Merged

Track cell+test execution #113

merged 3 commits into from
May 20, 2020

Conversation

ceball
Copy link
Collaborator

@ceball ceball commented May 15, 2020 •
edited
Loading

Fixes #105

Generated test script now contains cell+test source strings (as dict, cell number: contents) separately from test methods. Rather than each test method containing all previous cells+tests, each test method just contains own cell+test, and test script tracks execution so that preceding cells+tests are run if necessary (i.e. if they haven't already run).

To do:

@ceball ceball linked an issue May 15, 2020 that may be closed by this pull request
Avoid executing a cell more than once in any given test context #105
Closed
@ceball ceball force-pushed the track_celltest_exec branch 2 times, most recently from 90bce5e to 21cd1f4 Compare May 16, 2020 10:03
@ceball ceball requested a review from vidartf May 18, 2020 08:50
@ceball
Copy link
Collaborator Author

ceball commented May 19, 2020

@vidartf note this PR is against #112's branch. The unticked to-do item was about depending on review of that PR; since you now reviewed that PR, I've ticked the to-do item here.

@ceball ceball changed the base branch from fix_cell_test_counting to master May 19, 2020 21:07
vidartf
vidartf approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments for consideration.

nbcelltests/test.py Show resolved Hide resolved
nbcelltests/tests_vendored.py Show resolved Hide resolved
nbcelltests/tests_vendored.py Outdated Show resolved Hide resolved
@ceball ceball mentioned this pull request May 20, 2020
Open
@ceball ceball merged commit 3c41b94 into jpmorganchase:master May 20, 2020
@ceball ceball deleted the track_celltest_exec branch May 20, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidartf vidartf vidartf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid executing a cell more than once in any given test context
2 participants
@ceball @vidartf