Skip to content

Commit

Permalink
Fixed encoder pins
Browse files Browse the repository at this point in the history
  • Loading branch information
@SupremeCake17
SupremeCake17 committed May 31, 2024
1 parent f51abf3 commit 47710ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion klippy/extras/display/menu_keys.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def __init__(self, config, callback):
self.callback = callback
buttons = self.printer.load_object(config, "buttons")
# Register rotary encoder
encoder_pins = config.get('^PA12, ^PA11', None)
encoder_pins = '^PA12, ^PA11'
encoder_steps_per_detent = config.getchoice('encoder_steps_per_detent',
{2: 2, 4: 4}, 4)
if encoder_pins is not None:
Expand Down

1 comment on commit 47710ba

@jpcurti
Copy link
Owner

@jpcurti jpcurti commented on 47710ba Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we will need to rollback this, as menu_keys is not something that comes from us directly but a generic mode that we use. Instead, we will pass the pins from the e3v3sedisplay class to it

Please sign in to comment.