Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump js libraries #692

Closed
wants to merge 1 commit into from

Conversation

stereobooster
Copy link
Contributor

I didn't change anything, except I ran

npm i

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 50aa99b
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/654127275193b200083ffa57
😎 Deploy Preview https://deploy-preview-692--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

Your commit downgrades these dependencies! I don't think you're running the latest version of the codebase when you're invoking npm. Closing this issue as dependabot keeps dependencies up to date.

@jpanther jpanther closed this Oct 31, 2023
@jpanther jpanther added the non-issue Nothing needs to be fixed label Oct 31, 2023
@stereobooster
Copy link
Contributor Author

I don't think you're running the latest version of the codebase when you're invoking npm

strange. I pulled latest content from upstream. But maybe something is wrong in my setup

@stereobooster stereobooster deleted the bump-js-libraries branch October 31, 2023 21:58
@stereobooster
Copy link
Contributor Author

stereobooster commented Oct 31, 2023

But

"version": "2.7.1",
version in package-lock is not bumped

But if I run npm ci everything is ok

@jpanther
Copy link
Owner

That is more a side effect of the release process than an issue with dependencies as the package version is updated on deploy but I'm not specifically running npm install at that time which means the package-lock is always a version behind. But this shouldn't cause any issues when it comes to running a local build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Nothing needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants