nl80211: properly support split_wiphy_dump for single phys #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing a `NL80211_CMD_GET_WIPHY` request for a single wiphy with `split_wiphy_dump` set to true, the expectation is that only a single phy object is returned, like when performing the same request without splitting, yet the current implementation returns a sparse array with only the requested phy index populated instead. Fix this issue by special-casing NL80211_CMD_GET_WIPHY command requests with a set `split_wiphy_dump` attribute. Also implicitly set the `NLM_F_DUMP` flag in this case as it is required for the kernel to send all information. Signed-off-by: Jo-Philipp Wich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a
NL80211_CMD_GET_WIPHYrequest for a single wiphy withsplit_wiphy_dumpset to true, the expectation is that only a single phy object is returned, like when performing the same request without splitting, yet the current implementation returns a sparse array with only the requested phy index populated instead.Fix this issue by special-casing NL80211_CMD_GET_WIPHY command requests with a set
split_wiphy_dumpattribute. Also implicitly set theNLM_F_DUMPflag in this case as it is required for the kernel to send all information.