uci: fix potential memory leaks in configs()

In case `uci.cursor.configs()` is invoked with a completely empty configuration directory, the empty configuration list is not free before returning the `UCI_ERR_NOTFOUND` status. Signed-off-by: Jo-Philipp Wich <[email protected]>
jow- · Oct 11, 2023 · 9993ccb · 9993ccb
1 parent 2b2a472
commit 9993ccb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/uci.c b/lib/uci.c
@@ -1385,8 +1385,10 @@ uc_uci_pkg_command(uc_vm_t *vm, size_t nargs, enum pkg_cmd cmd)
 		if (uci_list_configs(*c, &configs))
 			err_return((*c)->err);
 
-		if (!configs || !configs[0])
+		if (!configs || !configs[0]) {
+			free(configs);
 			err_return(UCI_ERR_NOTFOUND);
+		}
 
 		for (i = 0; configs[i]; i++) {
 			if (!(p = uci_lookup_package(*c, configs[i])))