Skip to content

Commit

Permalink
Merge pull request #31 from joshuajaco/maintenance
Browse files Browse the repository at this point in the history
Maintenance
  • Loading branch information
joshuajaco authored Feb 16, 2024
2 parents bae5f04 + c4dfdc0 commit d661070
Show file tree
Hide file tree
Showing 5 changed files with 293 additions and 266 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [18.18.2, 20.9.0]
node-version: [18.19.1, 20.11.1]
steps:
- name: Set git to use LF
run: |
Expand All @@ -27,6 +27,6 @@ jobs:
- run: npm run lint
- run: npm test
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 20.9.0
nodejs 20.11.1
22 changes: 11 additions & 11 deletions docs/deprecating-scopes.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ Inside `project/.eslintrc.json`:
// ...
"rules": {
// ...
"workspaces/no-cross-imports": "error"
"workspaces/no-cross-imports": "error",
},
"overrides": [
{
"files": ["packages/user-management/**/*"],
"rules": {
"workspaces/no-cross-imports": [
"error",
{ "allow": ["@project/user-management-shared"] }
]
}
}
]
{ "allow": ["@project/user-management-shared"] },
],
},
},
],
}
```

Expand Down Expand Up @@ -82,8 +82,8 @@ Inside `project/.eslintrc.json`:
// ...
"rules": {
// ...
"workspaces/no-cross-imports": "error"
}
"workspaces/no-cross-imports": "error",
},
}
```

Expand All @@ -94,8 +94,8 @@ Inside `project/packages/user-management/.eslintrc.json`:
"rules": {
"workspaces/no-cross-imports": [
"error",
{ "allow": ["@project/user-management-shared"] }
]
}
{ "allow": ["@project/user-management-shared"] },
],
},
}
```
Loading

0 comments on commit d661070

Please sign in to comment.