Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step flow data #86

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Add step flow data #86

merged 4 commits into from
Mar 23, 2024

Conversation

joshtyf
Copy link
Owner

@joshtyf joshtyf commented Mar 20, 2024 •
edited
Loading

Description

  • Add step flow data to allow the frontend to build out the step graph.
  • steps field is now a map, with the key being the step name and the value the step itself (refer to Fetch service request latest step statuses #83 for step details)
  • Each step will now include next_step_name field.
    • If empty string "", then it is a terminal step
  • Add a first_step_name field to identify the start of the step graph easily

Part of #82

@joshtyf joshtyf added backend Backend related feature A new feature labels Mar 20, 2024
@joshtyf joshtyf added this to the M2: More features milestone Mar 20, 2024
@joshtyf joshtyf self-assigned this Mar 20, 2024
@joshtyf joshtyf linked an issue Mar 20, 2024 that may be closed by this pull request
Fetch latest step events #82
Closed
Ziyang-98
Ziyang-98 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee thanks. LGTM!

Zheng-Zhi-Qiang
Zheng-Zhi-Qiang approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joshtyf joshtyf merged commit 0c9c736 into main Mar 23, 2024
2 checks passed
@joshtyf joshtyf deleted the feature/add-step-flow-datat branch March 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang Zheng-Zhi-Qiang approved these changes

@Ziyang-98 Ziyang-98 Ziyang-98 approved these changes

Assignees

@joshtyf joshtyf

Labels
backend Backend related feature A new feature
Projects
None yet
Milestone
M2: More features
Development

Successfully merging this pull request may close these issues.

Fetch latest step events
3 participants
@joshtyf @Ziyang-98 @Zheng-Zhi-Qiang