Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add form data to service requests #77

Merged
merged 5 commits into from
Mar 10, 2024
Merged

Add form data to service requests #77

merged 5 commits into from
Mar 10, 2024

Conversation

joshtyf
Copy link
Owner

@joshtyf joshtyf commented Mar 3, 2024

Description

Added Form and FormData to both Pipeline and ServiceRequest respectively. I've also created validators that will validate:

  • Valid form when created together with a pipeline
  • Valid form data when created together with a service request

I'll utilise these validators in our API handlers in a separate PR.

Closes #76

@joshtyf joshtyf added backend Backend related feature A new feature labels Mar 3, 2024
@joshtyf joshtyf added this to the M2: More features milestone Mar 3, 2024
@joshtyf joshtyf self-assigned this Mar 3, 2024
Zheng-Zhi-Qiang
Zheng-Zhi-Qiang approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joshtyf joshtyf merged commit 0c5a927 into main Mar 10, 2024
2 checks passed
@joshtyf joshtyf deleted the feature/add-form-data-to-service-request branch March 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang Zheng-Zhi-Qiang approved these changes

@Ziyang-98 Ziyang-98 Awaiting requested review from Ziyang-98

@lylaaron98 lylaaron98 Awaiting requested review from lylaaron98

Assignees

@joshtyf joshtyf

Labels
backend Backend related feature A new feature
Projects
None yet
Milestone
M2: More features
Development

Successfully merging this pull request may close these issues.

Implement forms
2 participants
@joshtyf @Zheng-Zhi-Qiang