Add initial event logging for step execution #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziyang-98
reviewed
Mar 3, 2024
| type EventType string | ||
|
|
||
| const ( | ||
| STEP_STARTED EventType = "STEP_STARTED" |
There was a problem hiding this comment.
Does this mean there is only 4 events now? what happen to the other events? can lmk if anything needs to be changed/added to the existing events for the service request dashboard status column.
There was a problem hiding this comment.
I think the dashboard status column should show the overall status of the service request. The EventType you see here is more granular, and shows the event that has happened for this particular step. You won't be using this EventType for the status column
Ziyang-98
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added event logging for each step of each pipeline (
STEP STARTEDandSTEP COMPLETED). I'll add more logging for the subsequent steps and other events in another PR.Others
NOT STARTEDstatus