Add backend pipeline validation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziyang-98
approved these changes
Feb 17, 2024
|
@Ziyang-98 not too sure about needing approval on every request as some requests might not be as critical. we can implement it in the future if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pipeline validation logic. This PR mainly targets new created pipelines. I will create a separate validation in the future when updating pipelines.
I've yet to utilise the method
ValidatePipelineas I'm considering to create a middleware to validate the request body in the APIPOST /api/pipeline. This will be done in a separate PR.Closes #40