Organization Settings Page #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zheng-Zhi-Qiang
approved these changes
Jun 26, 2024
joshtyf
approved these changes
Jun 26, 2024
frontend/src/app/(authenticated)/(main)/settings/organization/_components/member-actions.tsx
Show resolved
Hide resolved
Comment on lines
+226
to
+232
| return apiClient.delete(`/membership`, { | ||
| data: { | ||
| user_id: userId, | ||
| org_id: orgId, | ||
| role: role, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
@Zheng-Zhi-Qiang why does this endpoint require the role parameter? if we are dependent on this parameter, it could be easily abused
There was a problem hiding this comment.
should be okay to remove, abused in what way though
There was a problem hiding this comment.
the backend api don't need body for delete though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new settings page, currently only has organization settings. Users will be able to change name of organization (need to be Owner) and perform CRUD functions to organization including:
Demo for changing organization name
2024-06-26.20-27-38.mp4
Demo for Viewing/Searching for members and adding new member
2024-06-26.20-27-59.mp4
Demo for Member actions and leaving of organization
2024-06-26.20-29-31.mp4
Other changes
SelectOrganizationsStatementSQL statement to check forfalsemembershipsPATCHto server allowed methods