Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/persisting generated log files and updating SR cancellation endpoint #149

Merged
merged 14 commits into from
May 26, 2024
Merged

Feat/persisting generated log files and updating SR cancellation endpoint #149

merged 14 commits into from
May 26, 2024

Conversation

Zheng-Zhi-Qiang
Copy link
Collaborator

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang commented May 22, 2024 •
edited
Loading

Description
In this PR, compose.yaml was amended to add a volume to persist logs in executor_logs.

Others

  • Removed starting of SRs from mongo seed
  • Added check for cancellation of SR to prevent continuous execution of pipeline once SR is cancelled
  • Updated SR cancellation handler to cancel both started and not started SRs, and to also create a step cancelled event for cancellable step events

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang self-assigned this May 22, 2024
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang added backend Backend related feature A new feature fix Fixes something labels May 22, 2024
Ziyang-98
Ziyang-98 approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshtyf
joshtyf reviewed May 23, 2024
View reviewed changes
Copy link
Owner

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for your input

backend/src/execute/step_exec_mgr.go Outdated Show resolved Hide resolved
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang changed the title Feat/persisting generated log files Feat/persisting generated log files and updating SR cancellation endpoint May 26, 2024
joshtyf
joshtyf requested changes May 26, 2024
View reviewed changes
Copy link
Owner

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just left a little request on the refactoring of the StepCompletedEvent

backend/src/execute/step_exec_mgr.go Outdated Show resolved Hide resolved
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang requested a review from joshtyf May 26, 2024 08:10
Ziyang-98
Ziyang-98 approved these changes May 26, 2024
View reviewed changes
Copy link
Collaborator

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end. Thanks!

joshtyf
joshtyf approved these changes May 26, 2024
View reviewed changes
Copy link
Owner

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for this!

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang merged commit 848b23e into main May 26, 2024
2 checks passed
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang deleted the feat/persisting-generated-log-files branch May 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziyang-98 Ziyang-98 Ziyang-98 approved these changes

@joshtyf joshtyf joshtyf approved these changes

Assignees

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang

Labels
backend Backend related feature A new feature fix Fixes something
Projects
None yet
Milestone
M3: Users & Organisation Management, ...
Development

Successfully merging this pull request may close these issues.
3 participants
@Zheng-Zhi-Qiang @joshtyf @Ziyang-98