Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/seeding process #139

Merged
merged 15 commits into from
May 20, 2024
Merged

Refactor/seeding process #139

merged 15 commits into from
May 20, 2024

Conversation

Zheng-Zhi-Qiang
Copy link
Collaborator

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang commented May 13, 2024 •
edited
Loading

Description

In this PR, I completed the following:

  • Seed additional data
  • Updated user model to save email as well
  • Added functionality to create auth0 user from the backend
  • Refactor posgres seeding to allow for slightly more flexibility in seeding
  • Updated docker compose down command to remove local images and volumes
  • Updated data seeding command

Others:

  • Added email property to FE User model

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang requested review from joshtyf and Ziyang-98 and removed request for joshtyf May 13, 2024 14:19
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang self-assigned this May 13, 2024
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang added backend Backend related feature A new feature refactor Code refactor or updates labels May 13, 2024
joshtyf
joshtyf reviewed May 14, 2024
View reviewed changes
Copy link
Owner

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

.DS_Store Outdated Show resolved Hide resolved
backend/database/init.sql Show resolved Hide resolved
backend/database/mongo_seed/main.go Outdated Show resolved Hide resolved
backend/database/postgres_seed/main.go Show resolved Hide resolved
backend/database/postgres_seed/main.go Outdated Show resolved Hide resolved
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang requested a review from joshtyf May 15, 2024 13:32
Ziyang-98
Ziyang-98 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end. Can give us example csv files for seeding? Thanks.

joshtyf
joshtyf approved these changes May 19, 2024
View reviewed changes
Copy link
Owner

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang merged commit 8bc4906 into main May 20, 2024
2 checks passed
@Zheng-Zhi-Qiang Zheng-Zhi-Qiang deleted the refactor/seeding-process branch May 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziyang-98 Ziyang-98 Ziyang-98 approved these changes

@joshtyf joshtyf joshtyf approved these changes

Assignees

@Zheng-Zhi-Qiang Zheng-Zhi-Qiang

Labels
backend Backend related feature A new feature refactor Code refactor or updates
Projects
None yet
Milestone
M3: Users & Organisation Management, ...
Development

Successfully merging this pull request may close these issues.
3 participants
@Zheng-Zhi-Qiang @joshtyf @Ziyang-98