Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pagination (for SRs only) #135

Merged
merged 12 commits into from
May 13, 2024
Merged

Conversation

joshtyf
Copy link
Owner

@joshtyf joshtyf commented May 7, 2024

Description

Implemented server side pagination for Service Request tables.

Need help

Setting the pagination options sets the state correctly, but there are 2 problems (see image):

  1. The next and previous page buttons are not working
  2. The UI does not update to show the newly selected page number
image

@Ziyang-98 could I get your help on this

Closes #126

@joshtyf joshtyf added frontend Frontend related backend Backend related feature A new feature labels May 7, 2024
@joshtyf joshtyf self-assigned this May 7, 2024
Copy link
Owner Author

@joshtyf joshtyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help @Ziyang-98

Copy link
Collaborator

@Ziyang-98 Ziyang-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshtyf joshtyf merged commit ae6d26c into main May 13, 2024
2 checks passed
@joshtyf joshtyf deleted the feature/integrate-pagination branch May 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related feature A new feature frontend Frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination
2 participants