-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pipeline form parsing #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine, but not really sure the intent behind it.
Let's do this in a separate PR as this is quite big already. It's a good suggestion. Let me create the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelogs:
Backend
FormField
with the following fieldsTitle
as the display title for the form fieldDescription
as the display description for the form fieldRequired
to determine whether field is mandatory (Note thatcheckboxes
field don't have this)MinLength
forinput
field minimum lengthOptions
forselect
andcheckboxes
fieldsDefault
as the default option forselect
fieldFormField
FormField
inhandleCreatePipeline
which returns error if validation failsFrontend
JsonFormComponent
to mirror BEFormField
model and updated all related objects to follow typesrjsf
parsing methods to convertform object intorjsf
formSchema
anduiSchema
Bruno
Notes
Bad Request
error message forhandleCreatePipeline
. Would be better if the BE can return the validation message directly, but I'm not sure how to return custom error messages in Go. @joshtyf need your advice and opinion on this.Demo
Demo for the flow of creating a Pipeline with Form to displaying of the Form in Service Request page. Showcased some of the validation too.
2024-04-13.17-15-43.mp4
Closes #92