Add a page to get the suggestions for what to throw into the crib #89

joshprzybyszewski · 2021-03-06T16:05:41Z

What broke / What you're adding

It'd be neat if we had a page that would show the calculated hand/crib pts for throwing different cards.

How you did it

Add a new directory for Suggestions. Currently, it will only suggest what to throw into the crib, but it'd also be neat to suggest what to peg next.

How to test it and how to try to break it

…'s currently balogna

joshprzybyszewski · 2021-03-06T16:06:54Z

client/src/app/containers/Suggestions/ChoosingCard.jsx

+  const updateValue=(_) => {
+    // TODO figure out how to get scroll capturing to work
+    // TODO update the value of this card in the state
+    console.log(`scrolled: ${card}`);
+  };
+  const updateSuit=(_) => {
+    // TODO update the state so that this card increments suits
+    console.log(`clicked: ${card}`);
+  };


These are the next things I'd like to do

Looks like scrolling --> change number, clicking --> change suit? Nice.

joshprzybyszewski · 2021-03-06T16:09:01Z

client/src/app/containers/Suggestions/SuggestionsTable.jsx

+          <TableRow>
+            <TableCell>Hand Points (avg)</TableCell>
+            <TableCell>Hand Points (median)</TableCell>
+            <TableCell>Crib Points (avg)</TableCell>
+            <TableCell>Crib Points (median)</TableCell>
+            <TableCell>Throw</TableCell>
+          </TableRow>


It would be awesome if we could get a table that has "merged cells" for the first header row, then has sub columns in the second header row so that we put | hand points | crib points | throw | in the first row and have avg | median | max as "sub columns" under each hand and crib. I haven't been able to figure that out yet, but it seems like this page should be able to help?

codecov · 2021-03-06T16:09:24Z

Codecov Report

Merging #89 (c9be6aa) into master (3f31648) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head c9be6aa differs from pull request most recent head 5c41068. Consider uploading reports for the commit 5c41068 to get more accurate results

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   70.07%   70.13%   +0.06%     
==========================================
  Files          80       80              
  Lines        3465     3465              
==========================================
+ Hits         2428     2430       +2     
+ Misses        819      818       -1     
+ Partials      218      217       -1

Impacted Files	Coverage Δ
server/play/cut.go	`50.00% <0.00%> (+5.88%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f31648...5c41068. Read the comment docs.

joshprzybyszewski · 2021-03-06T16:09:24Z

client/src/app/containers/Suggestions/index.jsx

+      <Grid
+        item
+        container
+        spacing={1}
+      ><GridList>
+          {handCards.map((card, index) => (
+            <ChoosingCard
+              key={`handcard${index}`}
+              card={card}
+            />
+          ))}
+        </GridList>
+      </Grid>


🔍 This could probably be split out into its own component?

joshprzybyszewski · 2021-03-06T16:09:43Z

client/src/app/containers/Suggestions/slice.js

+    handCards: [
+        'AH', 'KH', '5H', 'JH', '8C', '3D',
+    ],


🔍 I need a way to update this array

Write a reducer below that takes a string and an index to update?

joshprzybyszewski · 2021-03-06T16:09:57Z

client/src/app/containers/Suggestions/slice.js

+        setSuggestionResult: {
+            reducer: (state, action) => {
+                state.suggestedHands = action.payload.suggestions;
+            },
+        },


🔍 This is currently unused.

joshprzybyszewski

I'd like to have the client-side set up to just be using dummy data. Once I can edit the input hand adequately and see things update acceptably, I'd like to implement a REST endpoint on the server to accept the input and spit out the suggestions. Someday, it'd be neat if the client would just do all of the calculations

cszczepaniak · 2021-03-06T16:12:16Z

client/src/app/containers/Suggestions/ChoosingCard.jsx

+      onScroll={updateValue}
+      onClick={updateSuit}
+      className={classes.root}>


Why is our formatting messed up? I guess I need to revisit our tooling to see if we're formatting on commit

cszczepaniak · 2021-03-06T16:16:23Z

Reading through this code again makes me sorely miss TypeScript. I think we're going to want that ASAP

cszczepaniak · 2021-03-06T16:18:00Z

client/src/app/containers/LeftDrawer/LoggedInDrawer.jsx

@@ -6,6 +6,7 @@ import ListItem from '@material-ui/core/ListItem';
 import ListItemIcon from '@material-ui/core/ListItemIcon';
 import ListItemText from '@material-ui/core/ListItemText';
 import AddCircleOutlineIcon from '@material-ui/icons/AddCircleOutline';
+import SearchIcon from '@material-ui/icons/Search';


It's kinda cool and all that our linter comments on PRs but...

Can we just

Run lint on commit (with husky and lint-staged)

Run lint on PR builds

Number 1 should realistically prevent 99% of these lint comments from showing up.

cszczepaniak · 2021-03-06T16:19:39Z

client/src/app/containers/Suggestions/ChoosingCard.jsx

+import Card from '@material-ui/core/Card';
+import CardContent from '@material-ui/core/CardContent';
+import { makeStyles } from '@material-ui/core/styles';
+import Typography from '@material-ui/core/Typography';


🌵 These should prolly just use the named imports from '@material-ui/core'

cszczepaniak · 2021-03-06T16:20:30Z

client/src/app/containers/Suggestions/ChoosingCard.jsx

+    height: 160,
+  },
+  value: {
+    fontSize: 14,


We should keep font sizes in rem so they stay relative to a single reference size. Root font size is probably 16, so this would become '0.875rem'

cszczepaniak · 2021-03-06T16:27:56Z

client/src/app/containers/Suggestions/ChoosingCard.jsx

+    // TODO figure out how to get scroll capturing to work
+    // TODO update the value of this card in the state


For managing state, you could do:

// near the top of your component const [index, setIndex] = useState(0); // ... const updateValue = () => setIndex(prev => prev + 1); // or - 1, depending on scroll direction

I'm not sure what data onScroll feeds back to you, but that's at least the state management part

Oh wait, you want to update it in redux probably...

client/src/app/containers/Suggestions/ChoosingCard.jsx

cszczepaniak · 2021-03-06T16:30:08Z

client/src/app/containers/Suggestions/SuggestionsTable.jsx

+const SuggestionsTable = () => {
+  const sugs = useSelector(selectSuggestions);
+
+  if (!Array.isArray(sugs)) {


cries in typescript

cszczepaniak · 2021-03-06T16:30:57Z

client/src/app/containers/Suggestions/SuggestionsTable.jsx

+                      spacing={1}
+                    >
+                      <GridList>
+                      {sug.throw.map((card, index) => (


we should probably not name things throw since that's a keyword in JS

cszczepaniak · 2021-03-06T16:35:03Z

Glad to see cribbage is alive again 😎

…uggest Conflicts: logic/strategy/calculated_crib.go logic/strategy/calculated_hand.go logic/suggestions/utils.go network/suggest.go server/server.go

…uggest Conflicts: client/src/app/containers/LeftDrawer/LoggedInDrawer.jsx client/src/app/index.jsx

joshprzybyszewski added 3 commits March 6, 2021 08:42

wire up a new tab in the lhs panel that opens a suggestions page that…

1a18912

…'s currently balogna

start building the suggestions boxes

652560c

consider things

079f413

joshprzybyszewski requested review from cszczepaniak and amichael497 March 6, 2021 16:05

joshprzybyszewski commented Mar 6, 2021

View reviewed changes

cszczepaniak reviewed Mar 6, 2021

View reviewed changes

client/src/app/containers/Suggestions/ChoosingCard.jsx Outdated Show resolved Hide resolved

cszczepaniak reviewed Mar 6, 2021

View reviewed changes

joshprzybyszewski added 6 commits March 7, 2021 18:41

poke around at making the choosing card choosy

9cdbfe0

update internal state

fb58907

make a network request for the suggestions

fa17af7

move the logic out

8c331d6

implement the rest handler

6acb284

display the results from the server

f2068c8

joshprzybyszewski mentioned this pull request Mar 9, 2021

implement the suggestion hand logic only on the server #91

Merged

Merge branch 'master' of github.com:joshprzybyszewski/cribbage into s…

528fc5e

…uggest Conflicts: logic/strategy/calculated_crib.go logic/strategy/calculated_hand.go logic/suggestions/utils.go network/suggest.go server/server.go

joshprzybyszewski added 10 commits March 18, 2021 20:51

remove a file?

c98d926

Merge branch 'master' of github.com:joshprzybyszewski/cribbage into s…

adbbbf3

…uggest Conflicts: client/src/app/containers/LeftDrawer/LoggedInDrawer.jsx client/src/app/index.jsx

start the conversion to ts

1f6f5f9

update a few more things to ts

5a301cf

clean up a bunch of lints

1aa7eb8

compile!

c9be6aa

use the real thing

f205a2c

pass back cards

be50ed6

don't allow duplicates

3025c93

consistency?

5c41068

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a page to get the suggestions for what to throw into the crib #89

Add a page to get the suggestions for what to throw into the crib #89

joshprzybyszewski commented Mar 6, 2021

joshprzybyszewski Mar 6, 2021

cszczepaniak Mar 6, 2021

joshprzybyszewski Mar 6, 2021

codecov bot commented Mar 6, 2021 •

edited

Loading

joshprzybyszewski Mar 6, 2021

joshprzybyszewski Mar 6, 2021

cszczepaniak Mar 6, 2021

joshprzybyszewski Mar 6, 2021

joshprzybyszewski left a comment

cszczepaniak Mar 6, 2021

cszczepaniak commented Mar 6, 2021

cszczepaniak Mar 6, 2021

cszczepaniak Mar 6, 2021 •

edited

Loading

cszczepaniak Mar 6, 2021

cszczepaniak Mar 6, 2021

cszczepaniak Mar 6, 2021

cszczepaniak Mar 6, 2021 •

edited

Loading

cszczepaniak Mar 6, 2021

cszczepaniak commented Mar 6, 2021

		// TODO figure out how to get scroll capturing to work
		// TODO update the value of this card in the state

Add a page to get the suggestions for what to throw into the crib #89

Are you sure you want to change the base?

Add a page to get the suggestions for what to throw into the crib #89

Conversation

joshprzybyszewski commented Mar 6, 2021

What broke / What you're adding

How you did it

How to test it and how to try to break it

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 6, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshprzybyszewski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cszczepaniak commented Mar 6, 2021

Choose a reason for hiding this comment

cszczepaniak Mar 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cszczepaniak Mar 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cszczepaniak commented Mar 6, 2021

codecov bot commented Mar 6, 2021 •

edited

Loading

cszczepaniak Mar 6, 2021 •

edited

Loading

cszczepaniak Mar 6, 2021 •

edited

Loading