Fix name_when_new validation on multiselect with form scope name #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerei
force-pushed
the
fix-multiselect-free-text
branch
from
ad0f3bb to
80bc7c9
Compare
josefarias
approved these changes
May 21, 2024
There was a problem hiding this comment.
Stellar work @chloerei thanks for catching and fixing this. 👏
josefarias
reviewed
May 21, 2024
| @@ -204,7 +204,7 @@ def name_when_new | |||
| def name_when_new_on_multiselect_must_match_original_name | |||
| return unless multiselect? && name_when_new.present? | |||
|
|
|||
| unless name_when_new.to_s == name | |||
| unless name_when_new.to_s == hidden_field_name | |||
| errors.add :name_when_new, :must_match_original_name, | |||
| message: "must match the regular name ('#{name}', in this case) on multiselect comboboxes." | |||
There was a problem hiding this comment.
Just realized, would be good to use the hidden field name in the error message as well.
Would appreciate a separate PR if you have time. No worries if not.
There was a problem hiding this comment.
OK I will make separate PR.
josefarias
changed the title
josefarias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example form:
It will raise
But name
foo[bar]is correct. The comparison in the validation is the parameter name, which is not the name of the actual input.