fix: updates MathArray types to be n-dimensional

[orelbn]

Description

• Fixes MathArray types to allow for n-dimensional arrays.
• Addresses MathArray typescript type definition only handles 1D and 2D arrays #3098
• Also addresses issue discussed in: feat: adds unit support to ceil, floor, and fix functions #3269 (comment)
  

  mathjs/src/function/arithmetic/multiply.js

  Lines 799 to 807 in 982bbdc

  	'Array, Array': typed.referTo('Matrix, Matrix', selfMM => (x, y) => {
  	// check dimensions
  	_validateMatrixDimensions(arraySize(x), arraySize(y))
  	// use dense matrix implementation
  	const m = selfMM(matrix(x), matrix(y))
  	// return array or scalar
  	return isMatrix(m) ? m.valueOf() : m
  	}),

Test

• Added n-dimensional type tests
• Updated multiply tests

Additional Notes

• PR is made against the v14 release branch
• Continues from: Fixed MathArray TS type #3099

[orelbn]

Does multiplying arrays greater than 1-d together always result in an array, or can it result in a scalar? If that is the case, I can improve the multiplication types further.

[josdejong]

Thanks, looks good, this is a neat improvement!

Does multiplying arrays greater than 1-d together always result in an array, or can it result in a scalar? If that is the case, I can improve the multiplication types further.

Yes that is correct. I'll await the improvements that you have in mind before merging this PR 😄

[orelbn]

reater than 1-d together always result in an arr

Updated.

I did notice that when I multiply two arrays, where one contains a unit, the order matters because the conj function is not supported on units. I'm not sure if that is a possible future improvement for Conj.

[josdejong]

Thanks for the update 👍

I did notice that when I multiply two arrays, where one contains a unit, the order matters because the conj function is not supported on units. I'm not sure if that is a possible future improvement for Conj.

Good find, I would expect that to work both ways instead of just one. Can you open a separate issue for this?

Merging your improvemens in the v14 branch now!

[josdejong]

Published now in v14.0.0, thanks again.