Switch to putting config in a directory #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `wrapRc` to reference to add the `-u` argument to
neovim, we add the directory to the `XDG_CONFIG_DIRS`, which neovim will
read on startup.
This allows us to do a few nice things:
* Write commonly used code in modules. This is used to to
create an internal module, `flake/lsp`, which contains the
functions used for `on_attach` and the `capabilities`. Users can also
add their own modules via `vim.lua.modules.mymodule = "<code>";`.
* Put language specific code in `ftplugin/<lang>.lua`. The `nix`
config was migrated to use this approach as an example.
|
Sorry for the delayed response. This is an interesting feature which I am open to merging as an option that is by default disabled. This is because I see the primary use case of this flake being completely reproducible configurations that do not leak into your environment, hence the use of But I see why someone may want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
wrapRcto reference to add the-uargument to neovim, we add the directory to theXDG_CONFIG_DIRS, which neovim will read on startup.This allows us to do a few nice things:
flake/lsp, which contains the functions used foron_attachand thecapabilities. Users can also add their own modules viavim.lua.modules.mymodule = "<code>";.ftplugin/<lang>.lua. Thenixconfig was migrated to use this approach as an example.