Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src and out (revisited) #12

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jonkwheeler
Copy link

No description provided.

@jonkwheeler jonkwheeler changed the title Add src and out Add src and out (revisited) May 12, 2019
@jonkwheeler
Copy link
Author

jonkwheeler commented May 12, 2019

@joonhocho I tried to correct the merge conflicts BEST I COULD

I've got all of this working beautifully I think though.

When no flags are set...

Using tsconfig: /Users/jonwheeler/invision_code/eos-ds/tsconfig.types.json
Using compilerOptions.rootDir from your tsconfig
Using src: /Users/jonwheeler/folder/src
Using compilerOptions.outDir from your tsconfig
Using out: /Users/jonwheeler/folder/dist
Replaced 70 paths in 70 files

otherwise

Using tsconfig: /Users/jonwheeler/invision_code/eos-ds/tsconfig.types.json
Using flag --src
Using src: /Users/folder/src
Using flag --out
Using out: /Users/jonwheeler/folder/dist
Replaced 70 paths in 70 files

@jonkwheeler jonkwheeler mentioned this pull request May 12, 2019
@jonkwheeler
Copy link
Author

@vladjerca @jplew since you were interested in the last one, maybe you can test this one? Should be fully revamped and working. I tested with flags, without flags, and without the rootDir or outDir being in the second tsconfig file.

@jonkwheeler
Copy link
Author

jonkwheeler commented May 12, 2019

I also moved a log to be init if verbose is set. We can probably update the amount of verbose I think too. Maybe there's another way to do it, but I think the verbose flag should output 1 console log per file change, but not as default. Currently there's more logging than necessary, but no harm!

Copy link

@vladjerca vladjerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Works as expected on my projects with both the old inputs and by providing only the tsconfig.

@jonkwheeler
Copy link
Author

Just wanted to bump this 🤠

@halkeye
Copy link

halkeye commented Oct 9, 2019

@jonkwheeler Any chance you want to push this to a namespace on npm so more of us can use/try it?

@jonkwheeler
Copy link
Author

@halkeye yeah I can do that for ya. Bug me again if I haven’t done it within the next week.

@jonkwheeler
Copy link
Author

jonkwheeler commented Oct 10, 2019

@halkeye here you go https://github.com/jonkwheeler/tsconfig-replace-paths. I just tested it and it's working on my machine. Give it a whirl.

I plan to keep up-to-date on this and I'll probably move my projects to this in the next few days.

CC @vladjerca @blackholegalaxy

@halkeye
Copy link

halkeye commented Nov 20, 2019

@joonhocho we've been using this for a little while now. The new updates seen to work great.

@jonkwheeler thanks so much for keeping it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants