-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add src and out (revisited) #12
base: master
Are you sure you want to change the base?
Conversation
…aths into add-src-and-out # Conflicts: # src/index.ts
@joonhocho I tried to correct the merge conflicts BEST I COULD I've got all of this working beautifully I think though. When no flags are set...
otherwise
|
@vladjerca @jplew since you were interested in the last one, maybe you can test this one? Should be fully revamped and working. I tested with flags, without flags, and without the rootDir or outDir being in the second tsconfig file. |
I also moved a log to be init if verbose is set. We can probably update the amount of verbose I think too. Maybe there's another way to do it, but I think the verbose flag should output 1 console log per file change, but not as default. Currently there's more logging than necessary, but no harm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Works as expected on my projects with both the old inputs and by providing only the tsconfig
.
Just wanted to bump this 🤠 |
@jonkwheeler Any chance you want to push this to a namespace on npm so more of us can use/try it? |
@halkeye yeah I can do that for ya. Bug me again if I haven’t done it within the next week. |
@halkeye here you go https://github.com/jonkwheeler/tsconfig-replace-paths. I just tested it and it's working on my machine. Give it a whirl. I plan to keep up-to-date on this and I'll probably move my projects to this in the next few days. |
@joonhocho we've been using this for a little while now. The new updates seen to work great. @jonkwheeler thanks so much for keeping it up |
No description provided.