Add extra docs to Github package; light refactoring; bug fixes. #295
Conversation
* Rename `Package` and `GithubObject` classes to `AbstractPackage` and `AbstractGithubObject` respectively. * Deprecated `Package` and `GithubObject` classes. * Fix bug in create tag API. * Fix bug in `Teams::chekRepo` API (missing repo owner name - this is technically not backward compatible, but the old method would not anyway) * Added support for releases. * Added more examples to documentation.
| $action = $this->maps[$action]; | ||
| } | ||
|
|
||
| $method =sprintf('do%s', $action); |
There was a problem hiding this comment.
There is a missing space = sprintf
There was a problem hiding this comment.
That file should not have been included in the PR. I've removed it.
|
This is fully BC, correct? I see you kept the original classes, moved the contents to follow our naming convention to |
|
@dongilbert Is there any plan to open the 2.0 branch already ? |
|
I think so. We've been discussing possible changes for 2.0 since beta2. :) I don't see any reason why not. I'll open it to the team for discussion. — On Wed, Dec 4, 2013 at 4:27 PM, Florian Voutzinos
|
|
👍 |
|
Go for it!
|
|
Yes, I've made it fully b/c. |
Add extra docs to Github package; light refactoring; bug fixes.
PackageandGithubObjectclasses toAbstractPackageandAbstractGithubObjectrespectively.PackageandGithubObjectclasses.Teams::chekRepoAPI (missing repo owner name - this istechnically not backward compatible, but the old method would not
anyway)