Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quick Start section #100

Merged
merged 4 commits into from
Nov 15, 2017
Merged

Conversation

dbooth-boston
Copy link
Contributor

Added a simple Quick Start section to the README.md (via .verb.md).

@dbooth-boston
Copy link
Contributor Author

This addresses issues #98 and #99.

.verb.md Outdated
## Quick Start
Assuming you want to add a TOC to README.md:
1. ```$ npm install -g markdown-toc```
2. Edit README.md and insert the following line where you want the TOC inserted:<br />```<-- toc -->```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

<!-- toc -->

Missing !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch! I'll fix the PR in a moment ...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Your quick start was very useful to me as a new user 👍

Copy link
Collaborator

@doowb doowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dbooth-boston! There are a couple of changes that can be made. Also, will you remove the changes from the README.md (there seems to be an issue with the generated output). I'll update that after merging the PR.

.verb.md Outdated
@@ -1,3 +1,9 @@
## Quick Start
Assuming you want to add a TOC to README.md:
1. ```$ npm install -g markdown-toc```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need 1 backtick when the code is inline.

.verb.md Outdated
Assuming you want to add a TOC to README.md:
1. ```$ npm install -g markdown-toc```
2. Edit README.md and insert the following line where you want the TOC inserted:<br />```<!-- toc -->```
3. ```$ markdown-toc -i README.md```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need 1 backtick when the code is inline.

@doowb
Copy link
Collaborator

doowb commented Oct 25, 2017

Thanks @dbooth-boston! I requested some changes in a review. Once those are done, I'll merge.

@dbooth-boston
Copy link
Contributor Author

Ok @doowb it should be fixed now. I corrected the backticks and reverted the README.md . Thanks!

@dbooth-boston
Copy link
Contributor Author

@doowb it looks like this is approved and ready to merge now.

@doowb
Copy link
Collaborator

doowb commented Nov 15, 2017

@dbooth-boston thanks for the ping. I'll merge and get the readme updated soon.

@doowb doowb merged commit e10f43e into jonschlinkert:master Nov 15, 2017
@dbooth-boston dbooth-boston deleted the quick-start branch June 25, 2018 13:36
@TT--
Copy link

TT-- commented Nov 4, 2018

#96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants