Target Android 10, update permission handling #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
commented
Jul 28, 2020
This was referenced Jul 29, 2020
Closed
|
English looks fine to me!
Miquel-Àngel B. i F.
El dc., 29 jul. 2020, 00:58, Gerhard Olsson <[email protected]> va
escriure:
… ***@***.**** commented on this pull request.
------------------------------
In common/src/main/res/values/strings.xml
<#948 (comment)>:
> @@ -296,6 +296,11 @@
<string name="Share_workout">Share workout…</string>
<string name="New_audio_scheme">New audio scheme</string>
<string name="GPS_permission_required">GPS permission required</string>
+ <string name="GPS_permission_text_pre_Android10">Location permission required in system settings</string>
@Miniangel <https://github.com/Miniangel> any comments on the new strings?
GPS_permission_text_pre_Android10/GPS_permission_text and
Activity_recognition_text can be combined with Request_permission_text
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#948 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQDVOI6WK7LYYC2JCVPDJNTR55J2XANCNFSM4PK74STQ>
.
|
DEBUG only: show all accuracy values
For FileSynchronizer, save exports to a subdirectory of Documents, similar to the previous defaults. For db import/export use hardcoded getExternalFilesDir() and let the user copy files A file picker could be used eventually.
If permissions are denied, give motivation and let the user try again (unless "don't ask again" is ticked) Remove snackbar as it will not rerequest permissions if the user ticks "don't ask again". Instead use a popup that asks the user to go to system settings, without starting the workout. (Linking to system settings is not recommended in the guidelines.) TODO onRequestPermissionsResult() is not called, why permissions are checked onCreate (similar to how requested for autostart GPS) instead of when selecting Enable GPS.
gerhardol
force-pushed
the
feature/prepare-android-10
branch
from
5fa6bdc to
2d56681
Compare
gerhardol
force-pushed
the
feature/prepare-android-10
branch
from
2d56681 to
ccf6de6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to target Android 10 and prepare for Android 11 (R).
These changes will be mandatory either in a week or in October, depending on how you read the Google material.
See individual commits for details