Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mutliple backends #25

Closed
wants to merge 29 commits into from

Conversation

raldone01
Copy link

@raldone01 raldone01 commented Dec 21, 2020

I don't expect this pull request to get merged as the code changes are very drastic. The sdcard and ram backends are poorly tested. The sdcard backend should work though.

I really just want to show you what I have done. Your vfs abstraction really sped things up. Thanks for your work.

If you want add support for multiple backends you may be able to use some of my code in the future.

@BrianPugh
Copy link
Member

this is quite the PR. I've only skimmed it, I'll try and give it a thorough read when i have more time. Thank you for contributing!

@raldone01
Copy link
Author

raldone01 commented Jan 10, 2021

The first merge should be fine but it was a mistake using the github desktop app for the first time.

I added another commit to the pull request which adds a config option to allow unlink to also delete empty directories which is required if someone wants to use the ghc::filesystem on top of this as it only calls the remove function to delete folders and files. The std::filesystem is not yet functional even when the cpp17 flag is used.

# Conflicts:
#	.gitignore
#	CMakeLists.txt
#	Kconfig
#	README.md
#	include/esp_littlefs.h
#	sdkconfig.defaults
#	src/esp_littlefs.c
#	test/test_littlefs.c
@BrianPugh
Copy link
Member

I'm going to close this PR; it was a very cool contribution, but also quite large. To me, this was more of a puppy than a cake 😄 .

We now have SD support due to #170, and I think that was the most requested by users.

@BrianPugh BrianPugh closed this May 4, 2024
@raldone01
Copy link
Author

Understandable. SD support was the main reason for my changes. I actually think it's overcomplicated for what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants