-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mutliple backends #25
Conversation
this is quite the PR. I've only skimmed it, I'll try and give it a thorough read when i have more time. Thank you for contributing! |
…on to allow the remove call to also delete empty directories.
The first merge should be fine but it was a mistake using the github desktop app for the first time. I added another commit to the pull request which adds a config option to allow unlink to also delete empty directories which is required if someone wants to use the ghc::filesystem on top of this as it only calls the remove function to delete folders and files. The std::filesystem is not yet functional even when the cpp17 flag is used. |
# Conflicts: # .gitignore # CMakeLists.txt # Kconfig # README.md # include/esp_littlefs.h # sdkconfig.defaults # src/esp_littlefs.c # test/test_littlefs.c
I'm going to close this PR; it was a very cool contribution, but also quite large. To me, this was more of a puppy than a cake 😄 . We now have SD support due to #170, and I think that was the most requested by users. |
Understandable. SD support was the main reason for my changes. I actually think it's overcomplicated for what it does. |
I don't expect this pull request to get merged as the code changes are very drastic. The sdcard and ram backends are poorly tested. The sdcard backend should work though.
I really just want to show you what I have done. Your vfs abstraction really sped things up. Thanks for your work.
If you want add support for multiple backends you may be able to use some of my code in the future.