Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsPathArgument and AsPathOption attributes for paths autocompletion #589

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add AsPathArgument and AsPathOption attributes for paths autocompletion #589

merged 1 commit into from
Dec 5, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Dec 4, 2024 •
edited
Loading

Fixes #582

Example:
image

@joelwurtz
Copy link
Member

joelwurtz commented Dec 5, 2024 •
edited
Loading

Love it

Maybe not in this PR, but we could provide this automatically if the user exepect a SplFileInfo as a method parameter ?

@pyrech
Copy link
Member Author

pyrech commented Dec 5, 2024

Absolutetly.
We could also add later some kind of "base path" on the attributes to validate/force a certain location on the fs.

@pyrech pyrech merged commit 7592ee8 into main Dec 5, 2024
10 checks passed
@pyrech pyrech deleted the path-attribute branch December 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelwurtz joelwurtz joelwurtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify autocompletion for "path" arguments and option
2 participants
@pyrech @joelwurtz