Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handle #574

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix exception handle #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Console/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,12 @@ protected function getDefaultInputDefinition(): InputDefinition
return $definition;
}

private function enhanceException(\Throwable $exception): \Throwable
private function enhanceException(\Throwable $exception): void
{
if ($exception instanceof \Error) {
return;
}

$castorDirs = [
\dirname(__DIR__, 1),
\dirname(__DIR__, 2) . \DIRECTORY_SEPARATOR . 'vendor',
Expand All @@ -148,8 +152,6 @@ private function enhanceException(\Throwable $exception): \Throwable

break;
}

return $exception;
}

private function getLogo(): string
Expand Down
2 changes: 1 addition & 1 deletion tools/release/castor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function release(): int
check(
'Check the number of artifacts',
'There are not enough files in the artifacts directory.',
fn () => EXPECTED_ARTIFACTS === count($files),
fn () => EXPECTED_ARTIFACTS === \count($files),
);

check(
Expand Down