Rework the releasing #569
Merged
Rework the releasing #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
reviewed
Nov 14, 2024
| @@ -1,4 +1,4 @@ | |||
| In ProcessRunner.php line XXXX: | |||
| In functions.php line XXXX: | |||
pyrech
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current process has some issues. For example, we publish the release, and then
we build all artifacts in GHA. But this build took some time, and during the build
we broke all CI. Indeed, CI wants to download castor, it tooks the last release, but
artifacts are not yet there.
And for the v0.20.0, we had another issue: the release.created event was NOT fired :/
And we had other issues in the past, for example when a build fails, none files were uploaded.
E_TOO_MANY_PIT_FALL...
So we rewrote everything. Now the releasing is managed locally. We still use GHA to build all our artefacts.
But now we are able to publish a release with all artifacts at once 🎉
And we added tons of checks to ensure everything is okay.
Side notes:
fixes #520