Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): allow to define a default task #559

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat(task): allow to define a default task #559

merged 2 commits into from
Nov 13, 2024

Conversation

joelwurtz
Copy link
Member

@joelwurtz joelwurtz commented Nov 8, 2024

Fix #539

I also added a warning to tell user when there is multiple default, i think a warning is better in this case (instead of an exception) as we can always override default

image

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍🏼

Could you add a note in the CHANGELOG

Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should'nt we add a test for this feature?

doc/getting-started/basic-usage.md Outdated Show resolved Hide resolved
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pyrech pyrech merged commit a72ac03 into main Nov 13, 2024
10 checks passed
@pyrech pyrech deleted the feat/default-task branch November 13, 2024 13:56
@ruudk
Copy link
Contributor

ruudk commented Nov 13, 2024

Amazing! Gonna test it out when it's released. Thanks 🎉

@lyrixx
Copy link
Member

lyrixx commented Nov 13, 2024

@ruudk https://github.com/jolicode/castor/releases/tag/v0.20.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow defining a default task when running castor
4 participants