Merge pull request #399 from jolicode/fix/transient-tests

chore(tests): make some tests less sensible to user environment
jolicode · Apr 8, 2024 · e5a7acc · e5a7acc
2 parents 2229671 + 5af6ba7
commit e5a7acc
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 7 deletions.
diff --git a/examples/failure.php b/examples/failure.php
@@ -9,11 +9,11 @@
 #[AsTask(description: 'A failing task not authorized to fail')]
 function failure(): void
 {
-    run('i_do_not_exist', workingDirectory: '/tmp', pty: false);
+    run('bash -c i_do_not_exist', workingDirectory: '/tmp', pty: false);
 }
 
 #[AsTask(description: 'A failing task authorized to fail')]
 function allow_failure(): void
 {
-    run('i_do_not_exist', allowFailure: true, pty: false);
+    run('bash -c i_do_not_exist', allowFailure: true, pty: false);
 }
diff --git a/examples/ssh.php b/examples/ssh.php
@@ -27,7 +27,7 @@ function whoami(): void
 #[AsTask(description: 'Uploads a file to the remote server')]
 function upload(): void
 {
-    ssh_upload('/tmp/test.html', '/var/www/index.html', host: 'server-1.example.com', user: 'debian');
+    ssh_upload(__FILE__, '/var/www/index.html', host: 'server-1.example.com', user: 'debian');
 }
 
 #[AsTask(description: 'Downloads a file from the remote server')]

diff --git a/tests/Generated/FailureAllowFailureTest.php.err.txt b/tests/Generated/FailureAllowFailureTest.php.err.txt
@@ -1 +1 @@
-sh: 1: i_do_not_exist: not found
+bash: line 1: i_do_not_exist: command not found
diff --git a/tests/Generated/FailureFailureTest.php.err.txt b/tests/Generated/FailureFailureTest.php.err.txt
@@ -1,8 +1,8 @@
-sh: 1: i_do_not_exist: not found
+bash: line 1: i_do_not_exist: command not found
 
 In failure.php line 12:
 
-  The command "i_do_not_exist" failed.
+  The command "bash -c i_do_not_exist" failed.
 
 
 failure:failure

diff --git a/tests/Generated/SshUploadTest.php.err.txt b/tests/Generated/SshUploadTest.php.err.txt
@@ -2,7 +2,7 @@ ssh: Could not resolve hostname server-1.example.com: Name or service not known
 
 In SshRunner.php line XXXX:
 
-  The command "scp -r /tmp/test.html [email protected]:/var/www/index.html" failed.
+  The command "scp -r .../examples/ssh.php [email protected]:/var/www/index.html" failed.
 
 
 ssh:upload

diff --git a/tests/Slow/CompileCommandTest.php b/tests/Slow/CompileCommandTest.php
@@ -3,12 +3,20 @@
 namespace Castor\Tests\Slow;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Process\ExecutableFinder;
 use Symfony\Component\Process\Process;
 
 class CompileCommandTest extends TestCase
 {
     public function test()
     {
+        $finder = new ExecutableFinder();
+        $box = $finder->find('box');
+
+        if (null === $box) {
+            $this->markTestSkipped('box is not installed.');
+        }
+
         $castorAppDirPath = RepackCommandTest::setupRepackedCastorApp('castor-test-compile');
 
         (new Process(

diff --git a/tests/Slow/RepackCommandTest.php b/tests/Slow/RepackCommandTest.php
@@ -4,12 +4,20 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\Process\ExecutableFinder;
 use Symfony\Component\Process\Process;
 
 class RepackCommandTest extends TestCase
 {
     public function test()
     {
+        $finder = new ExecutableFinder();
+        $box = $finder->find('box');
+
+        if (null === $box) {
+            $this->markTestSkipped('box is not installed.');
+        }
+
         $castorAppDirPath = self::setupRepackedCastorApp('castor-test-repack');
 
         (new Process([
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		sh: 1: i_do_not_exist: not found
		bash: line 1: i_do_not_exist: command not found