Update value if any element of the array changes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwalley
commented
Jul 10, 2020
| value[0] !== newValue[0] || | ||
| (value.length > 1 && value[1] !== newValue[1]) | ||
| value.some(function (d, i) { | ||
| return d !== newValue[i]; |
There was a problem hiding this comment.
This isn't correct if newValue is shorter than value. Perhaps we could check if the arrays are the same length first? If they differ in length then we skip the check and always update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #138.
Previously we were only checking if the first two elements of the
valuearray had changed. If no change was found thenvaluewas not updated.