Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backend to be passed in to sendfile() #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaedroho
Copy link
Contributor

This pull request adds a kwarg called backend to sendfile(). It allows a different backend to be used for a particular view. It's also useful for third-party apps that want to use sendfile but provide a fallback if their users haven't set SENDFILE_BACKEND.

Example:

    from sendfile import sendfile
    from sendfile.backends.simple import sendfile as simple_sendfile

    def myview(request):
        ...

        return sendfile(..., backend=simple_sendfile)

Example:

    from sendfile import sendfile
    from sendfile.backends.simple import sendfile as simple_sendfile

    def myview(request):
        ...

        return sendfile(..., backend=simple_sendfile)
@johnsensible
Copy link
Owner

Interesting. Curious as to use case though? The library is just intended to paper over differences between sendfile/nginx/xsendfile etc. Seems odd that you might want a different backend for one particular application?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants