-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RPI #43
Open
slogan621
wants to merge
23
commits into
johnrickman:master
Choose a base branch
from
slogan621:rpi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnrickman please review, drop in replacement that now allows this code to support Raspberry PI. |
Please note that I have move this repo to https://gitlab.com/tandembyte/liquidcrystal_i2c |
I can’t find this on gitlab - returns a 404.
On Tue, Jul 7, 2020 at 7:53 AM John Rickman ***@***.***> wrote:
Please note that I have move this repo to
https://gitlab.com/tandembyte/liquidcrystal_i2c
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU7SOV3CAZBCBDSRBYT53R2MZH5ANCNFSM4OQSAP3A>
.
--
Syd Logan
|
Sorry, I put the wrong url. It is https://gitlab.com/tandembyte/LCD_I2C |
Okay, thanks.
On Tue, Jul 7, 2020 at 9:08 AM John Rickman ***@***.***> wrote:
Sorry, I put the wrong url. It is https://gitlab.com/tandembyte/LCD_I2C
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU7SJWK5OBTG53TT3JKQTR2NB75ANCNFSM4OQSAP3A>
.
--
Syd Logan
|
Where can this library be found that supports the rPi? The URl: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote LiquidCrystal_I2C.git to factor out Arduino-based code into an implementation class that can be instantiated on Arduino platforms at compile time. Coded a similar class that uses Linux-based i2c APIs, and supports Raspberry PI.
Nice thing is this library can now be used for both platforms. For Arduino, copy to the library directory as before. For RPI, it Makefiles are provided so it can be cross compiled (or compiled directly on the RPI) as a library, and then examples (such as CustomChars) can be ported to use it.
No changes are needed to the existing examples, they will work as in. cpp versions of HelloWorld and CustomChars were added, but mostly to add a main() that allows for specification of the i2c bus and the ID of the device.
Accepting this pull should not break existing arduino use cases, and will double the impact of this code bringing Raspberry PI community on board.