-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for jupyterlab 4 #14
base: main
Are you sure you want to change the base?
Conversation
Amazing! This is the PR we've all been waiting for (rather passively 😅 ). Thank you! 🙏 Would also close #6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this. How to proceed from here @onepan? You mention the need to set up the automatic pypi/conda publishing, should we set that up before merging these changes?
hmm actually I think I can just do all the non-admin stuff later this week. I think all you'd need to do is add a couple secrets then and we'd be set. We can do everything in one PR then |
Hey this is great! Thanks for updating this. Built locally and have been using it, will report back if I run into any issues, Thanks again! |
Following the development instructions on this branch got it working after changing one dependency I initially saw a build error with: I've been using it for about an hour without any issues so far. If anybody else wants to play with it:
Love the theme, thanks for the work on this! |
Not sure if it's relevant but I see that jupyterlab-pygments just made a release supporting JupyterLab 4 Would love to get OneDarkPro working in JupyterLab again! |
Tried to install from source on a fresh Jupyter 4 / python 3.11 env, but |
This just worked for me on Ubuntu 20.04, Python 3.10, JupyterLab 4.0.10. Appears to be working as expected so far.
Post your stack trace, maybe there is an issue with Python 3.11 or something else with your environment. |
Finally got it to work, but it was a rough journey 😮💨 :
Thanks again for the work on this. It would be awesome if this PR eventually gets merged 🙏 |
Migrates to the modern
pip/conda
install method and updates to jupyterlab 4There's still a bit of setup needed in the repo to automatically publish to pypi/conda-forge. Need to follow this guide. Instructions are also in
RELEASE.md
resolves #11