Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for jupyterlab 4 #14

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update for jupyterlab 4 #14

wants to merge 12 commits into from

Conversation

onepan
Copy link

@onepan onepan commented Jul 26, 2023

Migrates to the modern pip/conda install method and updates to jupyterlab 4

There's still a bit of setup needed in the repo to automatically publish to pypi/conda-forge. Need to follow this guide. Instructions are also in RELEASE.md

resolves #11

@slmg
Copy link

slmg commented Aug 13, 2023

Amazing! This is the PR we've all been waiting for (rather passively 😅 ). Thank you! 🙏

Would also close #6

Copy link
Owner

@johnnybarrels johnnybarrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this. How to proceed from here @onepan? You mention the need to set up the automatic pypi/conda publishing, should we set that up before merging these changes?

@onepan
Copy link
Author

onepan commented Aug 17, 2023

hmm actually I think I can just do all the non-admin stuff later this week. I think all you'd need to do is add a couple secrets then and we'd be set. We can do everything in one PR then

@kelseymcbratney
Copy link

Hey this is great! Thanks for updating this. Built locally and have been using it, will report back if I run into any issues,

Thanks again!

@davidwagnerkc
Copy link

davidwagnerkc commented Nov 9, 2023

Following the development instructions on this branch got it working after changing one dependency I initially saw a build error with:

image

I've been using it for about an hour without any issues so far. If anybody else wants to play with it:

git clone [email protected]:onepan/jupyterlab_onedarkpro.git
cd jupyterlab_onedarkpro
pip install -e .
jupyter labextension develop . --overwrite
# this was not in instructions, may have had to run explicitly because deps change
jlpm install  
# I may have run jlpm run build, not sure if there's a difference
jlpm build
jupyter lab

Love the theme, thanks for the work on this!

@zaneselvans
Copy link

Not sure if it's relevant but I see that jupyterlab-pygments just made a release supporting JupyterLab 4

Would love to get OneDarkPro working in JupyterLab again!

@slmg
Copy link

slmg commented Jan 23, 2024

Tried to install from source on a fresh Jupyter 4 / python 3.11 env, but pip install -e . is broken 😢

@davidwagnerkc
Copy link

@slmg

This just worked for me on Ubuntu 20.04, Python 3.10, JupyterLab 4.0.10. Appears to be working as expected so far.

git clone [email protected]:onepan/jupyterlab_onedarkpro.git
cd jupyterlab_onedarkpro/
pip install -e .
jupyter labextension develop . --overwrite

Post your stack trace, maybe there is an issue with Python 3.11 or something else with your environment.

@slmg
Copy link

slmg commented Jan 30, 2024

Finally got it to work, but it was a rough journey 😮‍💨 :

  1. Being behind a corporate proxy, I had to first configure jlpm (yarn really)

    jlpm config set httpProxy $HTTP_PROXY
    jlpm config set httpsProxy $HTTP_PROXY
  2. The command jupyter labextension develop . --overwrite tries to do a symlink at some point, which is not possible by default on windows and require elevated perms. Managed to work around this by copying the labextension folder manually

    # At the root of the repo
    cp jupyterlabl_ondedarkpro/labextension path/to/jupyter/env/share/jupyter/labextensions/jupyter_onedarkpro

Thanks again for the work on this. It would be awesome if this PR eventually gets merged 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLab 4.0
6 participants