Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter Zero PR #191

Merged
merged 71 commits into from
Feb 13, 2024
Merged

Chapter Zero PR #191

merged 71 commits into from
Feb 13, 2024

Conversation

bellabf
Copy link
Collaborator

@bellabf bellabf commented Jan 24, 2024

Hi,
These are the files related to the chapter zero.

Once we realized there were +60 contributors, we decided to put them in another files (which we haven't finished it yet).
All other files (welcome, learn, community) are there.

Thanks again!

cc: @seshu-pavan and @aman06012003

@merveenoyan
Copy link
Collaborator

@bellabf very sorry I wasn't clear enough. I meant if you could incorporate content (certification and so on) it would be great 😊

@seshupavan
Copy link
Contributor

I made some enhancements and typo fixes to welcome.mdx, mostly the contents taken from the notion document so it fits and aligns with the rest of the file.

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chapters/en/Unit 0 - Welcome/welcome.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 0 - Welcome/welcome.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! 🎉🎉 Thanks again @bellabf and @seshu-pavan for your wonderful work! Just left some small comments.

chapters/en/Unit 0 - Welcome/welcome.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 0 - Welcome/welcome.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@ratan ratan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ATaylorAerospace ATaylorAerospace merged commit b70e405 into johko:main Feb 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants