Changed __TOP_CARD and get_name_and_location function in Person.py #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeyism could you please verify the commit and merge the PR? |
|
This code doesnt work. throws an error |
|
It maybe because of other functions, they also need some rework :) |
|
Check out #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the '__TOP_CARD' from __TOP_CARD="pv-top-card" to __TOP_CARD="scaffold-layout__main"
The top_panel (for name and location) is taken as multi-class element ".mt2.relative"
Name is taken by TAG_NAME for top_panel as "h1"
Location is taken by multi-class name ".text-body-small.inline.t-black--light.break-words"
